Github user jzhuge commented on the issue:
https://github.com/apache/spark/pull/21911
Thanks @gatorsmile for the review and commit! Thanks @rdblue @mgaido91 for
the reviews!
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21911
You can address the comment in the follow-up PR. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21911
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94185/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94185/testReport)**
for PR 21911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94173/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94173 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94173/testReport)**
for PR 21911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94185/testReport)**
for PR 21911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94159/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94159/testReport)**
for PR 21911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94173/testReport)**
for PR 21911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94159/testReport)**
for PR 21911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94108/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94108/testReport)**
for PR 21911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94108/testReport)**
for PR 21911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94047/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94047/testReport)**
for PR 21911 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21911
> Which test suite is a good place to add such end-to-end case?
org.apache.spark.sql.SQLQuerySuite might be the best place.
> Do we plan to support such call as df.hint("COALESCE",
Github user jzhuge commented on the issue:
https://github.com/apache/spark/pull/21911
The new commit should have taken care of all review comments except the
following:
> Add an end-to-end test case.
Which test suite is a good place to add such end-to-end case?
>
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #94047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94047/testReport)**
for PR 21911 at commit
Github user jzhuge commented on the issue:
https://github.com/apache/spark/pull/21911
Thanks @gatorsmile. Will do.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21911
cc @maryannxue Please review it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21911
Generally, it looks good to me. Let us target this to the upcoming 2.4
release
We need to improve the test coverage:
- Add a test case when users specify multiple REPARTITION,
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21911
I'd like to fix the AnalysisError message and I noted one small nit in the
tests.
+1 when the AnalysisError message is fixed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93977/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #93977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93977/testReport)**
for PR 21911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #93977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93977/testReport)**
for PR 21911 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21911
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jzhuge commented on the issue:
https://github.com/apache/spark/pull/21911
The test `StreamingInnerJoinSuite.stream stream inner join on windows -
with watermark` might be flaky. It passed on my laptop.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93943/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21911
**[Test build #93943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93943/testReport)**
for PR 21911 at commit
38 matches
Mail list logo
