[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 Sure @lrytz can have a second look on this, also it needs to be battle tested. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21930 Yes we need to also create a 2.12 build of Spark in 2.4. We might still have to label it "beta" as I still kind of suspect there's a corner case lurking here. I can't speak for 3.0, but would assume

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @srowen thanks! So 2.12 will be optional for Spark 2.4? And the major version for Spark 3.0? What is the plan? --- - To

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21930 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-02 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @srowen gentle ping. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93916/ Test FAILed. ---

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93916/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93915/ Test PASSed. ---

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93915/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93916/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93915/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @srowen I think its ok now. Ready to go. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93879/ Test PASSed. ---

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93879/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @srowen that is my understanding too and yes they are erased AFAIK, but just in case I tried it... --- - To unsubscribe, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21930 I can imagine it is binary-compatible because the change is just to generic types, that are erased here (no ClassTags or anything). To be clear about source compatibility, do I have this

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93879/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93878/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93878/ Test FAILed. ---

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @srowen I updated the PR with the minor fixes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93878/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @felixcheung I tested with this simple program with Scala 2.11. The app jar was built against the officially released artifacts (2.3.1): ``` val spark = SparkSession .builder

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @felixcheung AFAIK as stated (@lrytz) in the doc it shouldnt be. It can be tested I guess. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-08-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21930 I think that's binary-incompatible breaking API change, right? ex. https://github.com/apache/spark/pull/21930/files#diff-2b8f0f66fe5397b169d0f754e99da8d5R64 ---

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21930 Yeah I would not worry about it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 > `logDebug(s\" + cloning the object $obj of class $` Is this normal? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93828/ Test PASSed. ---

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93828/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21930 cc @JoshRosen too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21930 @lrytz @retronym @adriaanm @srowen @felixcheung fyi, pls review. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21930 **[Test build #93828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93828/testReport)** for PR 21930 at commit

[GitHub] spark issue #21930: [SPARK-14540][Core] Fix remaining major issues for Scala...

2018-07-31 Thread holdensmagicalunicorn
Github user holdensmagicalunicorn commented on the issue: https://github.com/apache/spark/pull/21930 @skonto, thanks! I am a bot who has found some folks who might be able to help with the review:@pwendell, @cloud-fan and @mateiz ---