Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22019
@HyukjinKwon thanks for pinging me. Let's look at this and see if I can
make a PR soon.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22019
Probably I will not be able to look at this for the next a few weeks.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
@viirya and @MaxGekk, are you busy? Do you mind if I ask to take over this?
we will completely disallow empty strings in other types and target it 3.0.0.
The changes wouldn't be too much and it
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
Let me reopen a PR and proceed this after 2.4.0 or the code freeze
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22019
SGTM too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22019
SGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22019
I agree with this proposal @HyukjinKwon. I think it is wrong to consider as
a null an empty string. An empty string is not a valid value for an
int/double/... So in case we have, we should fail I
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
What do you guys think about completely disallow empty strings in other
types and target it 3.0.0? In theory, empty string is a string and I think
strictly it's more correct to disallow them.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22019
**[Test build #94342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94342/testReport)**
for PR 22019 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22019
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94342/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22019
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
I found this:
https://github.com/apache/spark/blob/branch-1.6/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala#L69
in branch-1.6 and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22019
> Empty string should be treated as null for all non string types?
I would exclude complex types.
---
-
To
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22019
Empty string should be treated as null for all non string types?
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22019
Hm.. wait let me take a closer look.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
15 matches
Mail list logo
