[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22039 > Yes, "quick hack", but, as opposed to what in these specific cases? Yes, that is the key question. I'll admit, I haven't looked at all deeply to try to figure out whether something

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22039 Yes, I agree about the future-proofing problem. However, at the moment, new future cases will also not cause any compile problem, but will just also trigger a MatchError. This is, simply, always a

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22039 Hmmm... sorry to be late to this, but making pattern matches exhaustive by adding a catch-all case that then throws an exception, while easy, should be considered as a less than optimal fix.

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22039 Also merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94435/ Test PASSed. ---

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22039 **[Test build #94435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94435/testReport)** for PR 22039 at commit

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94440/ Test FAILed. ---

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22039 **[Test build #94440 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94440/testReport)** for PR 22039 at commit

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22039 **[Test build #94440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94440/testReport)** for PR 22039 at commit

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22039 **[Test build #94435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94435/testReport)** for PR 22039 at commit

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22039 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22039 cc @kiszk @srowen @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,