Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
OK, it isn't just me. We'll see if it's a broader problem.
I manually cherry-picked to branch-2.4
---
-
To unsubscribe,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22048
Ur, it seems that I'm facing the same situation. In this case, should we
just cherry-pick to `branch-2.4`?
---
-
To
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22048
@srowen . Sure. I'll try to backport this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
@dongjoon-hyun could I ask a favor; can you try merging this? the merge
script should say it's merged and offer to back-port to 2.4. However I keep
getting errors about it not being mergeable,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
Merging to master and 2.4, though for some reason I can't back-port with
the merge script right now. Will try later.
---
-
To
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
I see, Thinks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
Just add a new commit with a little info about what this does and how you
generated it. The commits are squashed anyway.
---
-
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
LGTM, then let me ask @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22048
**[Test build #4329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4329/testReport)**
for PR 22048 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22048
**[Test build #4329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4329/testReport)**
for PR 22048 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
Hm! so the warning triggers on unicode escape sequences? That seems like a
bug in the style checker. Oh well, yes keep them. I'll retest ...
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
I see. A new commit has been done.
Thinks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22048
+1 for adding `scalastyle:off nonascii` in that part.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22048
style errors, we cannot include non-ascii characters in files;
```
Scalastyle checks failed at following occurrences:
[error]
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
Have a look at the test results, which show the style problem it flags:
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4305/console
```
[error]
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
Please help me @srowen
I don't know where I need to make changes.
---
-
To unsubscribe, e-mail:
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
Why did it fail?
What else should I do?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22048
**[Test build #4305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4305/testReport)**
for PR 22048 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22048
**[Test build #4305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4305/testReport)**
for PR 22048 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22048
Also, can you add tests in `DatasetSuite`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
I have moved the method of calculating the half width of a string into
util.Utils object.
@maropu @srowen
---
-
To
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
@xuejianbest thank you for your update. Would it be possible to commit test
cases, too?
---
-
To unsubscribe, e-mail:
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
I looked at all the 0x-0x characters (unicode) and showed them
under Xshell, then found all the full width characters. Get the latest regular
expression.
A new version has been
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22048
Ping @xuejianbest
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
Thank you for creating a JIRA entry and for putting the result. The test
case is not available yet.
---
-
To unsubscribe, e-mail:
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
---
-
To unsubscribe, e-mail:
Github user xuejianbest commented on the issue:
https://github.com/apache/spark/pull/22048
Below is the display effect I tested on Xshell5.
[https://issues.apache.org/jira/secure/attachment/12935462/show.bmp](url)
---
28 matches
Mail list logo
