[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 I'm going to say let's leave this alone for now then if there isn't consensus. We can easily reopen later if someone wanted to just add the JARs. ---

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/22084 I'm totally on the user's standpoint, compared to ship these slim jars, it would be better to ship the assembly jars, as those jars can be used directly by adding to Spark's runtime. For these

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 There's no policy stating you have to release all code as binary bits; it just seemed coherent to do so. It isn't a behavior change as it doesn't add anything to the jars/ directory, and won't

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/22084 From user's point, I don't think it is useful compared to pulling from maven repo, the provided jar alone is of no use. But if there's an Apache policy to release all the binaries, then I'm OK

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94700/ Test PASSed. ---

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22084 **[Test build #94700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94700/testReport)** for PR 22084 at commit

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22084 **[Test build #94700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94700/testReport)** for PR 22084 at commit

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 To maybe summarize: what this isn't doing is actually making these external modules available on the classpath for standalone mode. That would be a reasonable goal, as it would make standalone mode

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22084 +1 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 This script isn't exercised in the tests anyway, so the result is not meaningful. I manually tested it. --- - To unsubscribe,

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94648/ Test FAILed. ---

[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...

2018-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22084 **[Test build #94648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94648/testReport)** for PR 22084 at commit