Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22087
I also expose GMM's predictProbability.
could you please make a final pass? @srowen @felixcheung
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22087
ah, good point @imatiach-msft , I missed the `HasLabelCol` in
`PredictorParams`. We might have to revise the trait hierarchy here to
something like you mentioned. I do agree with @srowen to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98574/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98574/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98574/testReport)**
for PR 22087 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22087
Sounds good to design a universal prediction model as a super-class.
BTW, I think we can also create a new class `ProbabilisticPredictionModel`
(as a subclass of `PredictionModel`), so
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/22087
PredictionModel as a super-class of unsupervised and supervised seems sane
to me. Returning a double to unify the signature also seems sane, although the
thought of casting it might irk
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22087
@srowen @mgaido91 @erikerlandson I don't think it makes sense to use
PredictionModel as it is currently because it is for supervised learning and
contains label column specific params (eg
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22087
I'd escalate to dev@ for more visibility. It has some longer-term
consequences, and I'd like to hear current thinking on how much these APIs
should change, etc.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22087
@srowen I think it would not be a big deal if we would change the return
type of these to Double, since they are now private. If that is the only change
needed we may be able to reuse the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22087
Aha. On the one hand, I suppose they can't extend that class because of the
signature difference, and indeed it says it's the superclass of regression and
classification models. I can imagine that
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22087
@erikerlandson @srowen actually we already have a `PredictionModel` for
this. am not sure why clustering algorithms are not extending it though, but
in that class the method returns a `Double`,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22087
Yeah it's a good point and I wonder if @jkbradley or @mengxr or @MLnick
want to weigh in. If this superclass method existed, I think it would be
`predict(Vector):Int` anyway, so seems pretty
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/22087
This LGTM, but it raises a more general question about the lack of
single-sample prediction over the entire hierarchy. For example (IMO) there
should be some kind of single-sample method
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98502 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98502/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98502/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98502 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98502/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22087
@zhengruifeng thanks, the PR looks good to me, maybe @felixcheung or
@jkbradley can review and possibly merge?
---
-
To
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22087
@imatiach-msft Updated according to your comments! Thanks for your
reviewing!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98345/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98345/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98344/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98344/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98345/testReport)**
for PR 22087 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #98344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98344/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95990/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #95990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95990/testReport)**
for PR 22087 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #95990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95990/testReport)**
for PR 22087 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/22087
@felixcheung Testsuites is added. Thanks for reviewing!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94723/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #94723 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94723/testReport)**
for PR 22087 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #94723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94723/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94671/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #94671 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94671/testReport)**
for PR 22087 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22087
**[Test build #94671 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94671/testReport)**
for PR 22087 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22087
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
54 matches
Mail list logo
