[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22098 Let me just push this in. Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22098 haha, it's more then 4 years ago .. if we are unsure on the env, let me just push this in. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22098 oh wow, nice find @HyukjinKwon! code archaeology ftw! :) anyways: that PR went through about a week after i started here @ the amplab and i don't think i even had access to the build

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22098 @shaneknapp, seems this was first introduced in https://issues.apache.org/jira/browse/SPARK-3076 / https://github.com/apache/spark/pull/1974 for a good reason fwiw. One thing I am not

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22098 > > Ah, @shaneknapp , probably one possibility > about the motivation is that we don't touch build configuration often and > control the build time

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22098 Ah, @shaneknapp, probably one possibility about the motivation is that we don't touch build configuration often and control the build time within the codebase so that committers don't have to

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22098 to be honest, i have *no* idea why this was done in the first place... the jenkins build already has a timeout. i'll dig around today and see if i can't find out who put this in the repo

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22098 Hm.. makes sense. @shaneknapp WDYT? I can also log the timeout as well and default to `400m` if not set just in case for now. Would this make the things complicated? If so, let me just leave it

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22098 One suggestion: can we add a environment variable for the script execution timeout in Jenkins, so that we don't need to modify the hardcode value here? ---

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22098 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94722/ Test PASSed. ---

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22098 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22098 **[Test build #94722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94722/testReport)** for PR 22098 at commit

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22098 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22098 **[Test build #94722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94722/testReport)** for PR 22098 at commit

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22098 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22098: [SPARK-24886][INFRA] Fix the testing script to increase ...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22098 cc @shaneknapp --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: