Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22140
We are very conservative when backporting the PR to the released version.
---
-
To unsubscribe, e-mail:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22140
> Thanks for your understanding. Normally, we are very conservative to
introduce any potential behavior change to the released version.
Yes, I know. It seemed to me at the time as
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22140
@BryanCutler @HyukjinKwon Thanks for your understanding. Normally, we are
very conservative to introduce any potential behavior change to the released
version.
I just reverted it from
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22140
> Can we just simply take this out from branch-2.3?
Thanks @HyukjinKwon , that is fine with me. What do you think @gatorsmile ?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22140
Yea, actually I wouldn't at least backport this to branch-2.3 since the
release is very close. Looks a bug to me as well.
One nitpicking is the case with RDD operation:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22140
@gatorsmile it seemed like a straightforward bug to me. Rows with extra
values lead to incorrect output and exceptions when used in `DataFrames`, so it
did not seem like there was any possible
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
```
@xuanyuanking Could you please update the document?
```
#22369 Thanks for reminding, I'll pay attention in future work.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22140
@BryanCutler What is the reason to backport this PR? This sounds a behavior
change.
@xuanyuanking Could you please update the document?
---
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
Thanks @BryanCutler @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22140
merged to master, branch 2.4 and 2.3. Thanks @xuanyuanking !
---
-
To unsubscribe, e-mail:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22140
> yea, to me it looks less sense actually but seems at least working for
now:
good point, I guess it only fails when you supply a schema.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95756/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22140
**[Test build #95756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95756/testReport)**
for PR 22140 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22140
**[Test build #95756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95756/testReport)**
for PR 22140 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22140
@BryanCutler, for
https://github.com/apache/spark/pull/22140#issuecomment-414802978, yea, to me
it looks less sense actually but seems at least working for now:
```python
from
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
gental ping @HyukjinKwon @BryanCutler
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
AFAIC, the fix should forbid illegal extra value passing. If less values
than fields it should get a `AttributeError` while accessing as the currently
implement, not ban it here? What do you
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22140
Does it make any sense to have less values than fields? Maybe we should
check that they are equal, wdyt @HyukjinKwon ?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22140
cc @BryanCutler as well since we discussed an issue about this code path
before.
---
-
To unsubscribe, e-mail:
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94920/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22140
**[Test build #94920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94920/testReport)**
for PR 22140 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22140
**[Test build #94920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94920/testReport)**
for PR 22140 at commit
29 matches
Mail list logo
