[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22162 @AndrewKL Thanks for your work! I think we can add enough tests for this patch without using a spy library. --- - To

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22162 Can you fix the style errors? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22162 **[Test build #95804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95804/testReport)** for PR 22162 at commit

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95804/ Test FAILed. ---

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22162 **[Test build #95804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95804/testReport)** for PR 22162 at commit

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-07 Thread AndrewKL
Github user AndrewKL commented on the issue: https://github.com/apache/spark/pull/22162 Hey Friends, I have updated the commit and fixed most of the issues mentioned. I do have one remaining issue left which is the testing of the new show functionality. Currently the provided

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95775/ Test PASSed. ---

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22162 **[Test build #95775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95775/testReport)** for PR 22162 at commit

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22162 **[Test build #95775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95775/testReport)** for PR 22162 at commit

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-09-06 Thread AndrewKL
Github user AndrewKL commented on the issue: https://github.com/apache/spark/pull/22162 Hey Friends, Sorry for the delayed response. I've been in the desert 5 hours into the middle of no where. I'll incorporate the feed back and update this. ---

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22162 ya, sure. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22162 We should wait @AndrewKL for few days? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22162 I have much bandwidh to take it, too. Is it ok to take it over? @mgaido91 not working on this now? --- - To unsubscribe,

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22162 sure, no worries @kiszk, I can take it if needed. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22162 Would someone please take it? I have less bandwidth next two days since I will be in a training session at my office. --- -

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22162 sure @HyukjinKwon, thanks for pinging me anyway. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22162 @viirya, @kiszk, @mgaido91 and @maropu, would you be interested in taking this over if this gets inactive for few more days? ---

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22162 ping @AndrewKL --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95254/ Test PASSed. ---

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22162 **[Test build #95254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95254/testReport)** for PR 22162 at commit

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22162 **[Test build #95254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95254/testReport)** for PR 22162 at commit

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22162 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22162: [spark-24442][SQL] Added parameters to control the defau...

2018-08-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22162 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional