[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-12-05 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 @srowen Sorry for the late reply! I'd like to close this PR and file a new one since our SQL doc has changed a lot. Thank you all for your comments and time! ---

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-11-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22184 @seancxmao is this PR still live? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-11-11 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 @HyukjinKwon Thank you for your comments. Yes, this is only valid when upgrade Spark 2.3 to 2.4. I will do it. --- - To

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22184 @seancxmao, so this behaviour changes description is only valid when we upgrade spark 2.3 to 2.4? Then we can add it in `Upgrading From Spark SQL 2.3 to 2.4`. ---

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-09-10 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 @cloud-fan @gatorsmile I think the old `Upgrading From Spark SQL 2.3.1 to 2.3.2 and above` is not needed since we do not backport SPARK-25132 to branch-2.3. I'm wondering if we need `Upgrading

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-09-05 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 @cloud-fan I've just sent a PR (#22343) for this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22184 see `ParquetOptions`. Option can be specified per-query while SQL conf is per-session. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-29 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 > My proposal is, parquet data source should provide an option(not SQL conf) to ... You mentioned this option is not SQL conf. Could you give me some advice about where this option should be

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22184 > if spark.sql.hive.convertMetastoreParquet and spark.sql.caseSensitive are both set to true, we throw an exception I'd like to just skip the conversion and log a warning message to say

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-29 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 @cloud-fan OK, I will do it. Just to confirm, when reading from hive parquet table, if `spark.sql.hive.convertMetastoreParquet` and `spark.sql.caseSensitive` are both set to true, we

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22184 Since we are not going to backport the PR to 2.3, do we still need this migration guide? Strictly speaking, we do have a behavior change here: hive table is always case insensitive and

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22184 **[Test build #95262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95262/testReport)** for PR 22184 at commit

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95262/ Test PASSed. ---

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22184 **[Test build #95262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95262/testReport)** for PR 22184 at commit

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22184 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-22 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22184 @gatorsmile Could you kindly help trigger Jenkins and review? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional