[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-29 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 This will eliminate a race condition between FS shutdown (in the hadoop shutdown manager) and the hive callback. Theres a risk today that the filesystems will be closed before that event log

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/22186 The fix itself LGTM, but I don't think this could solve the STS shutdown hook conflict problem with Hadoop. --- - To

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22186 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95385/ Test PASSed. ---

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22186 **[Test build #95385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95385/testReport)** for PR 22186 at commit

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 The latest patch builds locally Maven test outcome * lots of json missing method errors, clearly jackson version problems of some kind * I don't see log messages of hive

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22186 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22186 **[Test build #95385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95385/testReport)** for PR 22186 at commit

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22186 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-28 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 My local build wasn't including that module; it now does and the link works with a subclass of `AbstractFunction0`. The local tests are failing under maven with hive/jackson mismatch

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-26 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 my local maven build *did* work, so maybe its a javac/JVM version thing. Will move back to a java class callback. --- -

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-24 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/22186 My local maven build also failed. I think the problem is that`ShutdownHookManager` is implemented in Scala, the complied method signature may be different when invoked from Java, I'm not

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-22 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 Not sure what is up with the build here; worked with mvn locally. Possibly my use of a java 8 lamda-expression as the hook? ---