[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-09-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22236 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95548/ Test PASSed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95548/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95548/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-31 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 yes, thanks, forgot to update in the Scala API, so I updated all them accordingly. Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95407/ Test PASSed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95407 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95407/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95407/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/22236 Take it and good luck. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95341/ Test PASSed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95341/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95341/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 @holdenk @srowen anyway I realized that computing the lift for previously saved models is not feasible as we don't know the number of training records, so we cannot compute the items support.

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 thanks for pointing that out @hhbyyh . I wasn't aware of it. I think lift and confidence are more useful metrics than the support (the votes on the JIRAs seem also to agree with me on this).

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/22236 just FYI about another related PR: https://github.com/apache/spark/pull/17280 and maybe I should close it? @srowen --- -

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95314/ Test PASSed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95314/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95314/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95294/ Test FAILed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95294/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95287/ Test FAILed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95287/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95294/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22236 Yeah, I like that idea. Just compute it on initializing the model. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 @srowen then what about recomputing when reading saved models? This seems a good compromise to me as it saves the writing of the data, it allows having lift for old models, but it doesn't

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95287/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95265/ Test FAILed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95265/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 cc @holdenk @srowen @yanboliang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95265/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95263/ Test FAILed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95263/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95263/testReport)** for PR 22236 at commit