Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
@HyukjinKwon Thank you for following up work on the PR. @cloud-fan @viirya
@maropu Thanks for your reviews.
---
-
To
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
Thanks all!!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97966/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97966 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97966/testReport)**
for PR 22237 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97958/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97958/testReport)**
for PR 22237 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
LGTM, pending jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
https://github.com/apache/spark/pull/22237/files#r223707899 makes sense to
me. Addressed. LGTM from my side as well
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97958/testReport)**
for PR 22237 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
Ah, yea I have a direct access to this branch. Let me just rebase/address
the comment tomorrow.
---
-
To unsubscribe,
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22237
@HyukjinKwon Got it. I won't take it since you will do it.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
Oh wait you left a sign-off. Let me rebase it within tomorrow - wouldn't be
a big job.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
If @gengliangwang find some time to work on this, yea please go ahead.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
@HyukjinKwon are you working on it? @gengliangwang do you want to take over?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97244/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97244/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97244/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97198/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97198 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97198/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97198 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97198/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97174/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97174 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97174/testReport)**
for PR 22237 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
LGTM except https://github.com/apache/spark/pull/22237/files#r223707899 ,
do you think it's reasonable?
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97174 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97174/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97157/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97157/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97157 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97157/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97037/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97037 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97037/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97037/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97016/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97016 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97016/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97016 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97016/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96992/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96992 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96992/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96993/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96993 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96993/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96992/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
@maropu May I ask you to look at it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96905/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96905/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96905/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96873/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96873/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96873/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
@HyukjinKwon Please, take a look at the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96772/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96772/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96772/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
> @MaxGekk is it difficult to add a conf?
@HyukjinKwon I will try.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
@MaxGekk is it difficult to add a conf?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
> I actually was thinking about targeting 3.0 but looks now we are going
ahead for 2.5. This bit is what I am less sure of for now actually.
The PR definitely changes existing behavior of
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22237
I manually ran some queries.
My point was about the value of the column `from_json`, `null` vs
`Row(null, null, ...)`.
Now I am +1 with the proposal of this PR, making the column
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96693/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96693/testReport)**
for PR 22237 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
The problem here is the difference between JSON functionality and JSON
datasource parsing. The JSON function was first added in a way of mimicking
PERMISSIVE mode but not exactly same.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22237
Hi @MaxGekk ,
I just reviewed this PR. I noticed that there is one behavior change. The
column value of `from_json(corrupt_record...)` become `Row(null, nulll, ...)`,
instead of `null`.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96684/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96693/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96684/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96684 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96684/testReport)**
for PR 22237 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
Seems okay.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96629/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96629/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96629/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
@HyukjinKwon Any chance the PR will be merged in the near future or I
should close it?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96205/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96205/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96205/testReport)**
for PR 22237 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22237
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96200/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96200/testReport)**
for PR 22237 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96200/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
@viirya @maropu @HyukjinKwon May I ask you to look at this one more time,
please.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22237
@HyukjinKwon Please, take a look at it again.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95896/
Test PASSed.
---
1 - 100 of 153 matches
Mail list logo
