Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22239
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22239
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95272/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22239
**[Test build #95272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95272/testReport)**
for PR 22239 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22239
Shall we rename it to: **[SPARK-19355][SQL][Followup] Remove the
child.outputOrdering check in global limit**?
---
-
To
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
@maropu Thanks. I just added it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22239
Better to add `in global limit` in the title?
Anyway, LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
Sure, thank you @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22239
LGTM - Let's wait a little bit with merging to allow others to comment.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22239
**[Test build #95273 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95273/testReport)**
for PR 22239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22239
Setting `spark.sql.limit.flatGlobalLimit` to `false` works for me.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
@hvanhovell I can set `spark.sql.limit.flatGlobalLimit` to false to match
`TakeOrderedAndProjectExec` semantics at the beginning of
`TakeOrderedAndProjectSuite`. Or you prefer to add an explicit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
> @viirya did you try to run TakeOrderedAndProjectSuite? I am pretty sure
that will fail now ;)...
Not yet. Let me try.
---
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22239
cc @cloud-fan for a sanity check.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22239
@viirya did you try to run `TakeOrderedAndProjectSuite`? I am pretty sure
that will fail now ;)...
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22239
**[Test build #95272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95272/testReport)**
for PR 22239 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22239
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22239
cc @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
20 matches
Mail list logo
