Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22262
@dongjoon-hyun Thank you!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
Thank you, @seancxmao .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
Merged to master/2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95827/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95827 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95827/testReport)**
for PR 22262 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95827 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95827/testReport)**
for PR 22262 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95824/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95825/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95825 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95825/testReport)**
for PR 22262 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95824 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95824/testReport)**
for PR 22262 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
The following is the sequence.
```scala
scala> sql("insert overwrite local directory '/tmp/parquet' stored as
parquet select 1 id, 2 id")
```
```
$ parquet-tools
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22262
> ... we need this duplication check in case-sensitive mode ...
Do you mean we may define ORC/Parquet schema with identical field names
(even in the same letter case)? Would you please explain
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
BTW, I think we need this duplication check in case-sensitive mode, too.
I'll ping on previous Parquet PR.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95825 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95825/testReport)**
for PR 22262 at commit
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22262
@dongjoon-hyun That's all right :). I have reverted to the first commit and
adjusted the indentation.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95824/testReport)**
for PR 22262 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
@seancxmao . I mistook yesterday. Could you restore to your first commit?
In the first commit, please adjust the indentation at [line
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95792/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95792/testReport)**
for PR 22262 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22262
**[Test build #95792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95792/testReport)**
for PR 22262 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22262
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
Thank you, @seancxmao .
Also, I made a PR to you, https://github.com/seancxmao/spark/pull/1 , to
simply the logic.
Could you review and merge that if you think that's okay?
---
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22262
I updated the PR description. Thank you for pointing that PR description
should stay focused. I also think it's more clear.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
Sorry, but I'm still feeling that this PR is losing focus. How about
mentioning what you do in this PR like the following?
```
Apache Spark doesn't create Hive table with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
Thank you, @seancxmao . I'll review tonight again.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22262
@dongjoon-hyun I have updated PR description to explain in more details. As
you mentioned, this PR is specific to the case when reading from data source
table persisted in metastore.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22262
@seancxmao . Could you explain why we need this PR? Apache Spark 2.3.1
already shows exceptions like the following for the case (for both ORC and
Parquet), doesn't it?
```scala
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22262
@dongjoon-hyun @cloud-fan @gatorsmile Could you please kindly review this?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22262
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
36 matches
Mail list logo
