Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jaroslawk commented on the issue:
https://github.com/apache/spark/pull/22309
I would love to have this change in - if anyone can review this and merge -
it would be great.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22309
adding @liancheng BTW. IIRC, he took a look for this one before and
abandoned the change (fix me if I'm wrongly remembering this).
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98248/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98248/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98248/testReport)**
for PR 22309 at commit
Github user mt40 commented on the issue:
https://github.com/apache/spark/pull/22309
@cloud-fan while what you said is true, I think it's not that bad. Overall,
the only major special logic is inside the case class `case` and this is due to
the special nature of value class.
On
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98200/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98200/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98203/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98203/testReport)**
for PR 22309 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22309
My only concern is, the value class handling is kind of spread out in
`ScalaReflection`. Maybe we need a better abstraction.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98200/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98203/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98170/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98170 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98170/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98167/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98167/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98160/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98160/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98158/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98158/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98170 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98170/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98167/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98160/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98158 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98158/testReport)**
for PR 22309 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22309
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98155/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98155/testReport)**
for PR 22309 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22309
According to the second rule, value class in Array needs to be
instantiated. In current code, I think it should go to the special handling
case of value class. Can you also add a test to verify it
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22309
How about value class in Array? Do we support it?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98155/testReport)**
for PR 22309 at commit
Github user mt40 commented on the issue:
https://github.com/apache/spark/pull/22309
@cloud-fan @viirya I was silly @_@, I forgot to push the change for that
part and missed that error message from Jenkins as well
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22309
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:401:
value isDefined is not a member of
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22309
try to build sql/core?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mt40 commented on the issue:
https://github.com/apache/spark/pull/22309
hi @viirya, may I ask whether Jenkins is having issue? It reports
```
[error] (catalyst/compile:compileIncremental) Compilation failed
[error] Total time: 175 s, completed Oct 27, 2018
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98154/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98154/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98154/testReport)**
for PR 22309 at commit
Github user mt40 commented on the issue:
https://github.com/apache/spark/pull/22309
@cloud-fan It works now. Actually, top level value class is supported from
[SPARK-17368](https://issues.apache.org/jira/browse/SPARK-17368). I try to
maintain that and add support for nested value
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98128/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98128/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #98128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98128/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97950/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97950 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97950/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97950 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97950/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97511/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97511/testReport)**
for PR 22309 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22309
what's still missing to support top level value class?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97511/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97360/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97360/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97360/testReport)**
for PR 22309 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22309
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mt40 commented on the issue:
https://github.com/apache/spark/pull/22309
@cloud-fan may I ask what is `error code -9`? I cannot find the error from
the log in Jenkin.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97331/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97331/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97331 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97331/testReport)**
for PR 22309 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97232/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97232 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97232/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97232 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97232/testReport)**
for PR 22309 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22309
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22309
somehow I lost track of this PR.
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user lbialy commented on the issue:
https://github.com/apache/spark/pull/22309
Hello. I've just found this PR while trying to debug serialization errors
for a case class containing value classes. This would be very helpful!
---
80 matches
Mail list logo
