Github user SongYadong commented on the issue:
https://github.com/apache/spark/pull/22348
Sounds reasonable. I will close this PR. Thank you!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22348
Thank you for experiment, @SongYadong . IMO, if the gain is not obvious, we
had better keep the current proven one because new one can introduce some
future regressions (or even bugs).
---
Github user SongYadong commented on the issue:
https://github.com/apache/spark/pull/22348
@dongjoon-hyun . You are right, DataSourceReadBenchmark result show the
benefit is too small even in some cases is covered up by fluctuation.
Java HotSpot(TM) 64-Bit Server VM
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22348
@SongYadong . `0.6%` seems to be too small to do this. Do you have another
benchmark result to show the benefit more clearly?
---
Github user SongYadong commented on the issue:
https://github.com/apache/spark/pull/22348
Could I ask you to review this PR if you have the time? cc @dongjoon-hyun
@cloud-fan
---
-
To unsubscribe, e-mail:
Github user SongYadong commented on the issue:
https://github.com/apache/spark/pull/22348
In my test, total executing time of 4885 spark applications:
origin: 447213 seconds
after : 444584 seconds
time saved : about 0.6%
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22348
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22348
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
