Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22366
I am going to close the PR since I don't see any reasons so far to maintain
it up to Spark 3.0.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22366
@dongjoon-hyun If you don't mind, I would create a separate PR and
deprecate the config in Spark 2.5 before removing it in Spark 3.0.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22366
Sure, +1 for keeping this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22366
> Only 3.0.0 will allow this.
@dongjoon-hyun I keep this PR open for a while. Maybe `2.5.0-SNAPSHOT` will
become `3.0.0-SNAPSHOT` in the near future.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22366
Sorry, @MaxGekk . It looks opposite to me. It's fixed at 2.3.1 and 2.4.0.
`2.5.0-SNAPSHOT` means we cannot do this for now. Only `3.0.0` will allow this.
How do you think about this,
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22366
@dongjoon-hyun The master branch became `2.5.0-SNAPSHOT` recently. Can we
move forward with this PR?
---
-
To unsubscribe,
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22366
> If this targets for 3.0, can we postpone this until the master branch
get 3.0.0-SNAPSHOT?
@dongjoon-hyun Yes, sure.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22366
@MaxGekk . If this targets for 3.0, can we postpone this until the master
branch get `3.0.0-SNAPSHOT`?
> The PR targets Spark 3.0 in which the flag can be removed.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22366
I think that it is good to describe the flag is removed. This is because
the default behavior is not changed and users can know the flag is not
effective in the next release.
cc @HyukjinKwon
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22366
> Is it better to add a description to docs/sql-programming-guide.md?
> Yea, let's note so that we can track what we change.
@kiszk @HyukjinKwon May I ask you to clarify this. Do you
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22366
Yea, let's note so that we can track what we change. cc @gatorsmile as well
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22366
Is it better to add a description to `docs/sql-programming-guide.md`?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95839/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22366
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22366
**[Test build #95839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95839/testReport)**
for PR 22366 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22366
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22366
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22366
**[Test build #95839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95839/testReport)**
for PR 22366 at commit
18 matches
Mail list logo
