Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
Thanx @vanzin!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@vanzin didn't mean to press or anything :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22381
You guys need to be a little patient...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@vanzin ready to merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97415/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #97415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97415/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #97415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97415/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@vanzin thanx for the review I think It looks ok now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@vanzin could I get a merge pls?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97324/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #97324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97324/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #97324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97324/testReport)**
for PR 22381 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
Thanx a lot @aditanase ! I will update the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user aditanase commented on the issue:
https://github.com/apache/spark/pull/22381
@skonto @vanzin You can rest assured the metrics are not shipped anywhere.
Collection is cheap/free and completely decoupled from reporting.
The registry is only a data bag, shipping metrics
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@vanzin AFAIK the operations just update metrics in the underlying
dropwizard metrics library. I dont htink anything is shipped anywhere. How
should I proceed? Is there anyone who is familiar with
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22381
I don't really have an opinion about the metrics or names or things like
that; but not being familiar with the internals of this metric system, I'd just
like to make sure that updating these metrics
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96215/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96215/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96215/testReport)**
for PR 22381 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22381
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22381
UT fixed by #22452.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22381
Looks like different failures. I am not sure if these are known issues. I'd
try again later today.
---
-
To unsubscribe, e-mail:
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@srowen integration tests seem so flaky! Seen this before?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96159/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96159/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96159/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
test failure is irrelevant. jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96153/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96153/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96153/testReport)**
for PR 22381 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@erikerlandson I added an option to disable them, by default they are now
disabled. Is it possible to move forward with this? @srowen ? Btw I removed any
code triggered by this unless explicitly
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96151 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96151/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96151/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96151 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96151/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96076/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96076/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96076/testReport)**
for PR 22381 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@erikerlandson I dont any tests for sources AFAIK, they exist for the
metric system itself. From the commit history this look like an old feature.
Regarding enabling or disabling them no at the
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/22381
These new metrics seem useful. Is there a way to provide unit or
integration testing for it?
Do these have enable/disable via metrics.properties files?
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
ok will do.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22381
Yeah, this is bigger than adding one metric; raise it on dev@? I'm not sure
who if anyone has an opinion on it. I'd rather hear more feedback on the
history of these choices and what the right
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@srowen I was checking git history and I see that you merged this one:
https://github.com/apache/spark/pull/22218 again related to metrics. Could you
call someone who can do the merge?
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@srowen thanks is there someone I could call? @vanzin ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22381
I don't think I know enough about monitoring to merge this. I am concerned
about the duplication here, although I understand your argument why it's
valuable.
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
@srowen @xuanyuanking ready for another round.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95905/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #95905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95905/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #95905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95905/testReport)**
for PR 22381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95881/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95880/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #95881 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95881/testReport)**
for PR 22381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #95880 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95880/testReport)**
for PR 22381 at commit
Github user dbrinegar commented on the issue:
https://github.com/apache/spark/pull/22381
This is quite a nice improvement for monitoring. The rest api is great for
UI and consolidated analytics, but monitoring through it is not as
straightforward as when the data emits directly from
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
> that mirroring of metrics seems like a bigger question
@srowen thanks for the comments, rest api is not always available or a
standard way to export stuff.
This is also the experience
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #95880 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95880/testReport)**
for PR 22381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #95881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95881/testReport)**
for PR 22381 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22381
please test this
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
88 matches
Mail list logo
