Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Gently ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
@cloud-fan I refactor and remove the function outputPath in
```DataWritingCommand```. Besides the unit test you could see, in my local, I
added below test in ```HiveQuerySuite.scala```:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22411
We can't merge new features to maintenance branches(2.4 as well), so we
don't need to rush here, as this feature can only be available in the next
release.
---
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Using pattern matching will face a problem.
```InsertIntoHiveDirCommand```,```CreateHiveTableAsSelectCommand``` and
```InsertIntoHiveTable``` are all in spark-hive module. SparkPlanInfo could not
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Agree that. Since this field is important to us. Could I refactor it
following your advice and file a discussion in another Jira?
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22411
Since this is a new feature, we can't just merge it like #22353 without a
proper design.
Making the event logs as a structured, unified and reliable source for
Spark metrics looks like a
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Most of the information we wanted could be analyzed out from event log
except some metrics in Executor side which doesn't heartbeat to Driver, e.g RPC
count with NameNode. Another case is #21221,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22411
Without a thorough design, I hesitate to change the `DataWritingCommand`
interface only for event log. Do you have any more plans to improve the event
log?
---
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
If almost implementations need to add to case statment, partten matching
each implementations seems weird and easy to causes missing when adds a new
implementation in future.
---
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Isn't common? I am afraid not only one InsertIntoHadoopFsRelation need to
added in case statment.
---
-
To unsubscribe,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22411
This time it's not a regression right? I'd like to not change the
interface, but explicitly catch the plan we are interested in `fromSparkPlan`,
e.g.
```
case DataWritingCommandExec(i:
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Gently ping @dongjoon-hyun @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22411
Gently ping @cloud-fan @dongjoon-hyun , would you please help to review?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22411
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
28 matches
Mail list logo
