Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@srowen Ok. I will close this PR and the bug.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22414
... look at the test failure at
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@srowen Can you give examples ? From what I have seen, invalid values
because of typo say `1 sec` throw exception at groupby().
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22414
I get it, but this becomes inconsistent, right? other invalid window values
aren't handled the same way.
---
-
To unsubscribe,
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@srowen Key benefit is fail fast particularly when running from spark-shell.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22414
Yeah, the test that failed here asserts that it's an `AnalysisException`. I
guess it could be removed. The thing is, many other cases are still handled as
`AnalysisException`. Maybe it's best to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22414
**[Test build #4374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4374/testReport)**
for PR 22414 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22414
**[Test build #4374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4374/testReport)**
for PR 22414 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
@raghavgautam Can you update this pr based on my patch? (sorry, but I have
no time to take this over...)
---
-
To unsubscribe,
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu Can you take a look ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
The problem is that the error message that we start getting is:
```
requirement failed: The window duration must be positive, but found:
-12096
```
Where as the error
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
How about this?
https://github.com/apache/spark/compare/master...maropu:pr22414
IMO simple fixes and tests are better.
---
-
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu Please continue with the review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
Plz do not change the format: `Problem` -> `What changes were proposed in
this pull request?`.
---
-
To unsubscribe, e-mail:
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu I have updated the PR description and answered your question, can
you continue with your review.
---
-
To
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
Please write the current behaviour (you described above) in the PR
description?
Also, can you format the PR description, too? you don't need the link to
the jira.
```
â¦alues should
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@maropu Can you continue with the review ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
The code below throws following error. Note that the error is produced at
the time of count() call instead of window() call.
```java
val df = spark.readStream
.format("rate")
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
btw, what's the current behaivour of Spark in case of the nagative value?
---
-
To unsubscribe, e-mail:
Github user raghavgautam commented on the issue:
https://github.com/apache/spark/pull/22414
@tdas Can you please take a look ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22414
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22414
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22414
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
23 matches
Mail list logo
