Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22466
@sandeep-katta Can you update the PR title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96929/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96929/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96929/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96766/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96766/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96768/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96768 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96768/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96768 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96768/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96766/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96750/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96750/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96750 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96750/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96736/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96736/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96736/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96730/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96730/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96730/testReport)**
for PR 22466 at commit
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
I am running the same test case with hive version **1.2.1.spark2** and it
is passing,can I know with what hive version CI is running and how
org.apache.hive.jdbc.HiveStatement and external
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96689/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96689/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96689/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96619/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96619/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96619/testReport)**
for PR 22466 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22466
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96601/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96601 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96601/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96601 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96601/testReport)**
for PR 22466 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22466
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
cc @cloud-fan @srowen I have updated the code,Please review
---
-
To unsubscribe, e-mail:
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
seems @cloud-fan comments are valid as it will not result in any behavior
change, I will update the PR accordingly WDYT @srowen
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22466
This is a behavior change and makes us different from Hive. However I can't
find a strong reason to do it. It's like importing a database, but we can't
automatically create table entries in the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22466
Owp, I've been misreading that several times. Right. Well by analogy, if a
database has a non default LOCATION then so do it's tables, and they are
treated like EXTERNAL tables. Dropping the DB
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22466
> That link says Hive does support EXTERNAL. What am I missing?
Hive supports `EXTERNAL` only for tables, not databases.
The CREATE TABLE syntax:
```
CREATE [TEMPORARY]
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22466
That link says Hive does support EXTERNAL. What am I missing? Well, in any
event we aren't contemplating a behavior change here.
If you delete a table with LOCATION specified, what should
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22466
yea, in Spark we conflate the two and treat a table as external if location
is specified.
However, Hive doesn't have external database, see:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22466
There is ... see
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ManagedandExternalTables
I think Spark conflates the two. It's rare (?) but possible to
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22466
I'm not sure if there is a concept called "external database" in Hive...
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22466
We should look at Spark documentation, and Hive, if any, to figure out what
the right behavior is here. Spark generally follows Hive. See
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
> See JIRA, I don't think this should be merged.
I have referred Databricks doc
https://docs.databricks.com/spark/latest/spark-sql/language-manual/create-database.html
and
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
Yes I agree 2 database should not point to same path,**currently this is
the loop hole in spark which is required to fix**.If this solution is not okay
,then we can append the dbname.db to
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22466
See JIRA, I don't think this should be merged.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/22466
@srowen @HyukjinKwon I think this can be a risk if the location of the
newly created database points to an existing one, if user drop the db both the
db data will be lost .
---
54 matches
Mail list logo
