[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-26 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 Another way is create a new css file such as historypage-specific.css, and add link in dataTablesHeaderNodes from UIUtils.scala, make new file only loaded when the table are used, like this:

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-26 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 Hi, @srowen, I find in SparkUI, the problem still exists: ![image](https://user-images.githubusercontent.com/10048468/46063474-80d1e400-c19f-11e8-890b-06297a9886cc.png)

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-25 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 > Rather than modify jquery, can we override this in Spark-specific CSS? otherwise we might lose customizations when updating jquery. Thanks for your advice, I think override is a

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22516 Rather than modify jquery, can we override this in Spark-specific CSS? otherwise we might lose customizations when updating jquery. ---

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-22 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22516 @Adamyuanyuan Thanks for the update! +1 for the option 1 :) --- - To unsubscribe, e-mail:

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-22 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 @gengliangwang Thanks for reminder, I also think this color is not good looking. I tried to change the background color before, but I'm not sure which is better, please give me some opinion to

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-21 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22516 Hi @Adamyuanyuan , Please specify the code changes in your PR description. I take a quick check and you have added ``` .paginate_button.active { outline: none;

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-21 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22516 Yes. I hit this issue also. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-21 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 We have the same problem, just change the css file jquery.dataTables.1.10.4.min.css can slove this miror. Although it's less modified, I think it is really important for spark history server

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22516 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22516 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22516 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional