[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-10-10 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22595 I read the original PR https://github.com/apache/spark/pull/14617, and it is wired that the two columns are hidden in the very beginning. Also the screenshot in PR description doesn't

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-10-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22595 CC @jerryshao for https://github.com/apache/spark/pull/14617 where this was added. It looks like the display is on purpose, but can you clarify? I don't think a "show additional columns" box

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-10-06 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 @srowen The checkbox is what I add in this PR to display/hidden the columns which have been hidden always. These columns are on heap memory, off heap memory. If we want to display them in

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-10-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22595 Not sure about this. It's not clear why the checkbox is there, what columns it controls. I don't perceive the UI as a problem right now. ---

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-10-01 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 cc @dongjoon-hyun @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 If this PR could be merged, #22578 could be added as an additional column as well. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 Gently ping @jerryshao @cloud-fan . Do you have a chance to review? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...

2018-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional