[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-13 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Hi @cloud-fan , Since other webtabs like jobs, stages etc. embed the javascript code in scala code, that is why I followed the same. It would be great if we rewrite the spark UI with some modern

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22645 I found the UI patches are very hard to review, because we embed HTML/Javascript in Scala code. Is there a plan to rewrite the Spark UI with some modern frontend frameworks? ---

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-12 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Thanks a lot @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22645 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22645 **[Test build #4361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4361/testReport)** for PR 22645 at commit

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22645 **[Test build #4361 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4361/testReport)** for PR 22645 at commit

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 @felixcheung It is a random failure. Could you please re-trigger the test. Thanks Please refer: https://issues.apache.org/jira/browse/SPARK-23622 ---

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22645 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97146/ Test FAILed. ---

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22645 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22645 **[Test build #97146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97146/testReport)** for PR 22645 at commit

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22645 **[Test build #97146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97146/testReport)** for PR 22645 at commit

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 @felixcheung I build locally, Now scalastyle issue is not happening. kindly re-trigger the PR builder. --- - To unsubscribe,

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Hi @felixcheung , I will update the code --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22645 @shahidki31 ^^ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22645 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97144/ Test FAILed. ---

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22645 **[Test build #97144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97144/testReport)** for PR 22645 at commit

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22645 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22645 **[Test build #97144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97144/testReport)** for PR 22645 at commit

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22645 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-08 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Hi @srowen , There is one behavior change this PR introduces, which is correct. Sorting Job Ids in the previous versions of spark was not proper. After the PR the sorting is proper.

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-06 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Thank you @srowen , I have modified the code based on your suggestions. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-06 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Thank you @srowen for the review. I have addressed the comments. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-05 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 Test step to reproduce OOM without the PR. 1) bin/spark-shell --conf spark.sql.ui.retainedExecutions=5 for (i <- 0 until 5) { val df = Seq( (1, 1),

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-05 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22645 cc @vanzin @srowen @cloud-fan @dongjoon-hyun . Kindly review the PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22645 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22645 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional