Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22756
reverted from master. Let's move the discussion to
https://github.com/apache/spark/pull/22764
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22756
yes, I agree, if we are not going to deprecate it in 2.4, we need to revert
also on master because of @cloud-fan's comment.
This would mean we won't have coherency with `KMeans` though,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22756
shall we revert it from master as well? At least we need to update the
message `This method is deprecated and will be removed in 3.0.0.`
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22756
Done
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22756
Let me revert it. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22756
We have to revert this PR in branch-2.4. It is not a blocker and we
shouldn't merge it to branch-2.4 this late in this already delayed release.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22756
cc @mengxr WDYT? It does not sound a blocker to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22756
I also understand today's situation and agree with @holdenk 's thought
about SPARK-25765 as a blocker. Ping @cloud-fan since you are a release
manager. How can we proceed SPARK-25765?
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22756
I'm seeing this linked from https://github.com/apache/spark/pull/22764 and
I'm wondering if we need to revert this. If the information is not actually
available where we tell folks it is I think we
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22756
Thank you, @mgaido91 and all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22756
Merged to master/branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/22756
LGTM. thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22756
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97525/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22756
**[Test build #97525 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97525/testReport)**
for PR 22756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22756
**[Test build #97525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97525/testReport)**
for PR 22756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22756
@dongjoon-hyun sure, thanks. I'll update asap. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22756
@mgaido91 . If you don't mind, could you split this PR into two PRs? One is
adding `deprecation` annotation only. The other is adding new API and updating
all examples?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97501/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22756
**[Test build #97501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97501/testReport)**
for PR 22756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22756
**[Test build #97501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97501/testReport)**
for PR 22756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22756
cc @holdenk @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97495/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22756
**[Test build #97495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97495/testReport)**
for PR 22756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22756
**[Test build #97495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97495/testReport)**
for PR 22756 at commit
34 matches
Mail list logo
