Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
Thanks! Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/22771
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
@markhamstra any further comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98083/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98083 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98083/testReport)**
for PR 22771 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98083 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98083/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22771
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98073/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98073/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98073/testReport)**
for PR 22771 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98056/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98056/testReport)**
for PR 22771 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98056/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22771
no other comments, looks good.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97941/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97941/testReport)**
for PR 22771 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
I agreed that the task reaper is a big change to the story and we should
reconsider SPARK-17064. Could we move the discussion to SPARK-17064?
By the way, regarding this PR itself,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97941 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97941/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22771
`PagedTableSuite.pageNavigation` failure is fixed in the master.
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22771
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97937/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97937/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97935/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97935/testReport)**
for PR 22771 at commit
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/22771
> We can at least try to abort the tasks and still honors the interrupt on
cancel flag. It seems like best case is things actually get killed and we free
up resources, worst case seems to be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97937/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97935/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22771
@markhamstra thanks for the reference, I was looking for some background on
this. I agree those are still issues like mentioned in SPARK-17064 but I
don't think that directly impacts this. We
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97878/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97878/testReport)**
for PR 22771 at commit
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/22771
There are long-standing questions here that I don't think have yet been
adequately answered -- cf. https://issues.apache.org/jira/browse/SPARK-17064
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97878/testReport)**
for PR 22771 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
@tgravescs Yeah, looks like that
https://issues.apache.org/jira/browse/SPARK-24622 is better but it may take
more time than this one, since this PR is smaller and less risky.
---
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22771
Actually as part of the jiras I mentioned above we were looking at killing
other task attempts as soon as one task attempt succeeds rather then waiting
for the entire job to finish, thoughts on
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22771
the change itself seems reasonable we were actually looking at this
recently as there are a couple of others bugs around this:
https://issues.apache.org/jira/browse/SPARK-25250 and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97562/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97562 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97562/testReport)**
for PR 22771 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
cc @squito @tgravescs @jiangxb1987 @kayousterhout
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97562 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97562/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
64 matches
Mail list logo
