[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22817 **[Test build #98038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98038/testReport)** for PR 22817 at commit

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-25 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/spark/pull/22817 I will try to investigate a bit more come up with an other solution. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-25 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/spark/pull/22817 So based on the UT results it seems that simply changing the resolution to bottom-up causes issues with `LambdaFunction`s in the current version of Spark. The issue seems to be a

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22817 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22817 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97985/ Test FAILed. ---

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22817 **[Test build #97985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97985/testReport)** for PR 22817 at commit

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/spark/pull/22817 Thanks @gatorsmile , I thought the issue in SPARK-25816 and in the added UT is because the top-down. I thought that `UnresolvedExtractValue(child, fieldExpr) if child.resolved` could be resolved

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22817 This would not work, since we need both bottom-up and top-down. You would hit the test failure. --- - To unsubscribe,

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22817 **[Test build #97985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97985/testReport)** for PR 22817 at commit

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22817 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22817 @peter-toth what are you trying to fix here? Could you add this to the PR description? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22817 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22817 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22817: [SPARK-25816][SQL] ResolveReferences should work bottom-...

2018-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22817 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional