[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-11-05 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/22869 LGTM too. Merged into master. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-11-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22869 cc @dbtsai --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-11-05 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22869 any comments on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22869 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22869 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98168/ Test PASSed. ---

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22869 **[Test build #98168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98168/testReport)** for PR 22869 at commit

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22869 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22869 **[Test build #98168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98168/testReport)** for PR 22869 at commit

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22869 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...

2018-10-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22869 Since https://github.com/apache/spark/pull/22756 was reverted because it was decided not to deprecate this in 2.4, but only in 3.0, this PR deprecates it for 3.0. cc @cloud-fan