[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-11-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22873 thanks, merging to master/2.4! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-11-06 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/22873 LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-11-05 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22873 any comments on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22873 **[Test build #98196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98196/testReport)** for PR 22873 at commit

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98196/ Test PASSed. ---

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22873 **[Test build #98196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98196/testReport)** for PR 22873 at commit

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22873 @viirya I think we can remove it as it is used nowhere. The point is: even if we remove it, we will remove it only on 3.0, so for 2.4 we should anyway fix this IMO. ---

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22873 Are we considering to remove it? If no, as `save` now calls `SaveLoadV2_0`, it seems good to update this variable. --- - To

[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion

2018-10-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22873 cc @cloud-fan @huaxingao @mengxr @WeichenXu123 @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For