Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Thank you @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22914
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98450/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98450/testReport)**
for PR 22914 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98450/testReport)**
for PR 22914 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Hi @HyukjinKwon, Could you please retrigger the PR builder?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98436/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98436 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98436/testReport)**
for PR 22914 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98436 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98436/testReport)**
for PR 22914 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
@srowen @gengliangwang There is one more place where the WEBUI can throw an
exception.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98426/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98426 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98426/testReport)**
for PR 22914 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98426/testReport)**
for PR 22914 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98417/testReport)**
for PR 22914 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22914
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98417/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #98417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98417/testReport)**
for PR 22914 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #4408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4408/testReport)**
for PR 22914 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #4408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4408/testReport)**
for PR 22914 at commit
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Thank you @gengliangwang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
I have tested all the scenarios in the WEBUI, and it is working as per
expected.
---
-
To unsubscribe, e-mail:
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
We can remove the method 'prevPageSizeFormField' from pagedTable and
corresponding page classes. Because this method is no longer required, as it
was for checking IndexOutOfBound.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
I have modified based on @gengliangwang 's suggestion. Also, we can remove
the check for page size in all the page class, because we handle the same in
the pagedTable class.
---
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Hi @srowen , After the PR, the following check also can be removed, because
the check is for preventing the OutOfBoundException, But no OutOfBound
exception happens after the PR.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Hi @gengliangwang , Yes. That also doable. Currently when the
IndexOutOfBound Exception comes, the page is navigating to the first page. Also
to make the behavior consistent with the page size
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22914
Yes if the behavior is consistent across pages that sounds like fine
behavior.
---
-
To unsubscribe, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22914
> Returning to current page seems more code change is required. Because we
are getting all the parameters related to page from the url. Currently we are
not passing any parameter to get which
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
Hi @srowen , The current behavior of WEBUI is,
1) When user enters a page size more than current page size, It falls back
to first page (In all the pages)
2) When the user enters a page
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22914
Returning to the current or last page seems fine too. No error message
really needed IMHO.
However it sounds like other pages already go to the 1st page on invalid
input? I'd also like to stay
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22914
> May be we can highlight above the table, that "Invalid page number,
falling back to first page"
Yes, that's what I mean.
No big deal but falling back to the first page seems
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
The current behavior is, If we enter a value more than the maximum page
number, the page navigation bar shows the user is in first page and throws an
exception. So, if we really want to throw
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22914
I prefer to just highlight the invalid output. E.g.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22914
@gengliangwang IMHO, We should try to avoid exceptions in the WEBUI.
User will come to know which page he is, from the page navigation bar.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22914
**[Test build #4400 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4400/testReport)**
for PR 22914 at commit
44 matches
Mail list logo
