Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
Let me go ahead with documenting one then tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
True. but it's a bit difficult to say it's a downside because `-i` has a
quite major issue as described above - user's code suddenly does not work with
implicit method (like symbol `'id` or
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22919
This is weird. The most obvious downside is that there's no way to get the
new `-i` functionality in case anyone needs it. A blurb in `--help` or even a
release note explaining the changed behavior
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22919
Tough call. At least it's worth documenting that this behavior changed
because so did the Scala shell's behavior, and I'd support that. I'd also
support supporting both, if there's no real downside
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
Thabks, @dbtsai. Also adding @vanzin and @srowen wdyt about -i options at
2.4.x and 3.0.0?
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22919
Thanks, @dbtsai . That sounds reasonable and helpful, too.
---
-
To unsubscribe, e-mail:
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22919
I'm also on @cloud-fan's side---we should keep it consistent with the
upstream Scala Shell. However, we should document it on `./bin/spark-shell
--help`, so when a user complains or files a ticket,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22919
+1 for @HyukjinKwon 's opinion .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
Also, the difference introduced between `-i` and `-I` sounds rather a bug
fix ([SI-7898](https://issues.scala-lang.org/browse/SI-7898)), which already
exists in previous shell. I ended up with
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
Note that `python` shell also takes file but `pyspark` shell doesn't:
```
$ cat tmp.py
print "a"
```
```
$ python2 tmp.py
a
```
```
$
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
I was actually thinking that hard about that. My conclusion was that
basically we should but `spark-shell` is a Spark entry point where we make a
release - so I thought it's better to keep it
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22919
personally I think Spark Shell should be consistent with the upstream Scala
Shell, otherwise we may get another ticket complaining why we didn't follow...
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22919
Yup. That's what I thought. and treat them as same
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22919
so we would support both `-i` and `-I` in 2.4?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
14 matches
Mail list logo
