[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-10 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 re https://github.com/apache/spark/pull/22963#issuecomment-437133365 i checked, and the only one we can seemingly download independently is pycodestyle. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22963 I also agree with @srowen's (https://github.com/apache/spark/pull/22963#issuecomment-437133365) --- - To unsubscribe,

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22963 OMG, I don't know why I missed these comments. I will read it tomorrow (now it's 6 am and I could get sleep .. ) --- - To

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-09 Thread rekhajoshm
Github user rekhajoshm commented on the issue: https://github.com/apache/spark/pull/22963 > pydocstyle tests passed w/o issue btw: > https://amplab.cs.berkeley.edu/jenkins/job/ubuntuSparkPRB/134/consoleFull > > this is on ubuntu w/python 3.5, flake8 3.6.0, pydocstyle 3.0.0

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-09 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 orthogonal to this PR, but just as an FYI: https://github.com/apache/spark/pull/22994 --- - To unsubscribe, e-mail:

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-08 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 > I don't have the context here to have a strong opinion, but, it seems like we should make the test env setup self-contained if possible, to avoid dependencies on and maintenance of the build

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-08 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 pydocstyle tests passed w/o issue btw: https://amplab.cs.berkeley.edu/jenkins/job/ubuntuSparkPRB/134/consoleFull this is on ubuntu w/python 3.5, flake8 3.6.0, pydocstyle 3.0.0 and

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22963 I don't have the context here to have a strong opinion, but, it seems like we should make the test env setup self-contained if possible, to avoid dependencies on and maintenance of the build env.

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-08 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 interesting. from the flake8 webpage: ``` It is very important to install Flake8 on the correct version of Python for your needs. If you want Flake8 to properly parse new language

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-08 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 ok, i missed that previous comment about flake8 and pycodestyle version incompatibility. since we're running flake8 3.50, i agree that this could be causing problems w/pycodestyle

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-08 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22963 sorry to jump in late on this, but i just wanted to check in on some of this stuff... `dev/lint-python` is a nightmare and i just wanted to discuss a couple of things: 1) the script

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22963 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22963 Thanks, @srowen and @dongjoon-hyun. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98549/ Test PASSed. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98549/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22963 cc @srowen, @holdenk and @rekhajoshm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98549/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98548/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98548/ Test FAILed. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98548/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98547/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98547/ Test FAILed. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98547/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98546/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98546/ Test FAILed. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98546/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98545/ Test FAILed. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98545/testReport)** for PR 22963 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98545/testReport)** for PR 22963 at commit