Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22989
`AssertionError` in tests is wrong. It should really just call `fail()`. If
you're willing to fix that, it would be a great cleanup.
The `AssertionError` in UnsafeAlignedOffset is legitimate
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98731/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98731/testReport)**
for PR 22989 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98731/testReport)**
for PR 22989 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22989
cc all reviewer, as @srowen's suggestion, add a rule to ban all of new
Error cases.
List currently `throw new XXXError` in Spark source below and record fix up
or exclude for review
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22989
Sorry for late reply, great thanks for all reviewer's advise, will address
them soon.
---
-
To unsubscribe, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22989
and catching Error or Throwable..
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22989
Honestly it is bad style to throw any Error class, except in sepcial
situations. I'd prefer a rule banning all of these and fix up any instances in
the code or else exclude them
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98649/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98649/testReport)**
for PR 22989 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98649/testReport)**
for PR 22989 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22989
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98637/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98637/testReport)**
for PR 22989 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22989
**[Test build #98637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98637/testReport)**
for PR 22989 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
26 matches
Mail list logo
