Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22998
yes, I agree with @cloud-fan , this can create wrong results with nulls...
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22998
I think this is wrong. We have to zero out the bytes even writing a null
decimal, so that 2 unsafe rows with same values(including null values) are
exactly same(in binary format).
---
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22998
@kiszk thank you for review it.
- when writing null decimalsï¼
```
OpenJDK 64-Bit Server VM 1.8.0_163-b01 on Windows 7 6.1
Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22998
@mgaido91
thank you for review it. I added a test case to test "write a decimal with
16 bytes and then one with less than 8". then the current change the remaining
8 bytes would not dirty.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22998
I have two questions.
1. Is this PR already tested with `"SPARK-25538: zero-out all bits for
decimals"`?
2. How does this PR achieve performance improvement? This PR may introduce
some
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22998
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22998
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22998
cc @mgaido91, @dongjoon-hyun , @cloud-fan , @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22998
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
