[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-03 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/23010 But we may forget to filter null values when we write sql. The following function protects this situation and writes the value of null partitions as __HIVE_DEFAULT_PARTITION__ def

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-03 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/23010 @cloud-fan, Thanks for review, Do you mean we should filter out invalid partitions in sql before write? --- - To unsubscribe,

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23010 The root cause is, `DynamicPartitionDataWriter` treats null and empty string as different partition values, and creates new files. However, null and empty string are converted to

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/23010 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99576/ Test PASSed. ---

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23010 **[Test build #99576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99576/testReport)** for PR 23010 at commit

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/23010 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-12-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23010 **[Test build #99576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99576/testReport)** for PR 23010 at commit

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98715/ Test FAILed. ---

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-11-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23010 **[Test build #98715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98715/testReport)** for PR 23010 at commit

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dy...

2018-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23010 **[Test build #98715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98715/testReport)** for PR 23010 at commit