Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
Last comment was a minor comment for a doc - actually the whole point was a
minor one. It does related with Windows.
---
-
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23055
(Belated +1.) Doc update looks fine. The previous one was misleading for
reasons that Ryan explains above, it has nothing to do with whether it's
Windows or not.
---
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23055
@HyukjinKwon, for the future, I should note that I'm not a committer so my
+1 for a PR is not binding. I'm fairly sure @vanzin would +1 this commit as
well, but it's best not to merge based on my
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
Thanks, @rdblue.
Merged to master and branch-2.4.
---
-
To unsubscribe, e-mail:
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23055
+1 with the latest changes. Thanks for taking care of this, @HyukjinKwon!
Functionality is in two parts: changing the resource requests (which
doesn't change) and limiting memory use in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99531/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99531 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99531/testReport)**
for PR 23055 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
@vanzin and @rdblue, I updated the doc because it sounds not wrong to me.
But, for clarification, we shouldn't really document we support something
that's not tested (in particular such case
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99531/testReport)**
for PR 23055 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23055
+1 once the docs are updated to note that resource requests still include
python memory, even in Windows.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99491/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99491 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99491/testReport)**
for PR 23055 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99490/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99490/testReport)**
for PR 23055 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99491 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99491/testReport)**
for PR 23055 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
24 matches
Mail list logo
