[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23075 @ssimeonov Thank you for your contribution to Spark. We wait for your next PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/23075 Also backported to 2.3/2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/23075 Merging to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99061/ Test PASSed. ---

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23075 **[Test build #99061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99061/testReport)** for PR 23075 at commit

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23075 **[Test build #99061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99061/testReport)** for PR 23075 at commit

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/23075 Let's see if this works :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/23075 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23075 jenkins, retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/23075 Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23075 @hvanhovell Could you trigger a build, please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-18 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23075 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-18 Thread ssimeonov
Github user ssimeonov commented on the issue: https://github.com/apache/spark/pull/23075 @MaxGekk done --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-18 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23075 > Which suite would you like me to add the test in? Please, create new test suite. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-18 Thread ssimeonov
Github user ssimeonov commented on the issue: https://github.com/apache/spark/pull/23075 @MaxGekk I see no mention of `AggregateExpression` in the `sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions` subtree. Which suite would you like me to add the test in? ---

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-18 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23075 Would you mind to add a test for case which you described in JIRA ticket? --- - To unsubscribe, e-mail:

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional