[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-21 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/23090 Backport PR for 2.2: https://github.com/apache/spark/pull/23115 Both 2.2 and 2.3 are retested. --- - To

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-21 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/23090 Backport PR for 2.3: https://github.com/apache/spark/pull/23114 --- - To unsubscribe, e-mail:

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-21 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/23090 Thanks @dongjoon-hyun, of course I will create those PRs. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/23090 Thank you, @squito , @attilapiros , @srowen . Then, @attilapiros , could you send backporting PRs against `branch-2.3` and `branch-2.2` please? ---

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/23090 btw I agree this was bad judgement on my part to only backport to 2.4, sorry abotu that and thanks for catching @dongjoon-hyun . I do think this fixes a bug (the ability to use the UI when you are

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/23090 I would prefer to override this 8k limit when it is really necessary (and only with the extent which justified by the production system). ---

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/23090 I think the default is pretty reasonable in most cases, in that this is the first time we've heard of someone hitting this limit. I'm not sure how high we would make it to get around this problem

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23090 Why not just hard-code a much higher limit? what's the consequence? in a generic public web server I can see that this defends against malicious or malformed requests, but that's much less an issue

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/23090 I understand the situation. However, according to the content of the patch, it's an improvement to add a missing configuration, @attilapiros . ```

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/23090 @dongjoon-hyun, @squito it is my bad, this problem is present in earlier releases as well. If I can change the issue type I modify it to Bug. ---

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/23090 Hi, @squito . SPARK-26118 is marked as 'Improvement', we don't backport 'Improvement'. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/23090 merged to master / 2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23090 **[Test build #4434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4434/testReport)** for PR 23090 at commit

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23090 **[Test build #4434 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4434/testReport)** for PR 23090 at commit

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23090 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23090 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99023/ Test FAILed. ---

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23090 **[Test build #99023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99023/testReport)** for PR 23090 at commit

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23090 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99019/ Test FAILed. ---

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23090 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23090 **[Test build #99019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99019/testReport)** for PR 23090 at commit

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23090 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99018/ Test FAILed. ---

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23090 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23090 **[Test build #99018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99018/testReport)** for PR 23090 at commit

[GitHub] spark issue #23090: [SPARK-26118][Web UI] Introducing spark.ui.requestHeader...

2018-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23090 **[Test build #99023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99023/testReport)** for PR 23090 at commit