Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23152
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
LGTM, thanks for the change!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99602/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99602 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99602/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99602 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99602/testReport)**
for PR 23152 at commit
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99597/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99597/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99597/testReport)**
for PR 23152 at commit
Github user adrian-wang commented on the issue:
https://github.com/apache/spark/pull/23152
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99586/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99586/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99586/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user adrian-wang commented on the issue:
https://github.com/apache/spark/pull/23152
@juliuszsompolski I have updated it accordingly, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
This reproes it:
```
sql("create table all_null (attr1 int, attr2 int)")
sql("insert into all_null values (null, null)")
sql("analyze table all_null
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
While at it, could we kill one more potential for a bug?
In `FilterEstimation.evaluateBinaryForTwoColumns` there is a
```
attrLeft.dataType match {
case StringType
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99508/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99508/testReport)**
for PR 23152 at commit
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23152
LGTM, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99508/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99498/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99498/testReport)**
for PR 23152 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99498 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99498/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99483/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99483/testReport)**
for PR 23152 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23152
good catch! Like @liancheng said, this is a real bug (a numeric column with
all values null), it's better to have an end-to-end test case for it.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/23152
CC @liancheng @juliuszsompolski @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99483/testReport)**
for PR 23152 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23152
Agreed. But looks like the added test was failed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23152
We should still make this change right, even if it doesn't manifest as an
actual bug right now? does the test need an update?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99431/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99431/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99431/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99425/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99425/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99425/testReport)**
for PR 23152 at commit
Github user adrian-wang commented on the issue:
https://github.com/apache/spark/pull/23152
@srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99314/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99314 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99314/testReport)**
for PR 23152 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99314 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99314/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user adrian-wang commented on the issue:
https://github.com/apache/spark/pull/23152
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99305/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99305/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23152
**[Test build #99305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99305/testReport)**
for PR 23152 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23152
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
74 matches
Mail list logo
