Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23153
a late LGTM as well, thanks @cloud-fan for the patch and thanks
@xuanyuanking for the review.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23153
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99358/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23153
**[Test build #99358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99358/testReport)**
for PR 23153 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23153
**[Test build #99358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99358/testReport)**
for PR 23153 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23153
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99356/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23153
**[Test build #99356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99356/testReport)**
for PR 23153 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23153
**[Test build #99356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99356/testReport)**
for PR 23153 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23153
the change itself seems fine to me, as @xuanyuanking mentioned, though, we
should update the existing tests. What about adding a test in the new suite
checking the plans instead of a end-to-end
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/23153
Thanks for the fix from Wenchen,
```
the suites should also construct the dummy python udf from both side.
```
I fix the suite locally, they can be simply modified like:
```
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23153
**[Test build #99324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99324/testReport)**
for PR 23153 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99324/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23153
**[Test build #99324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99324/testReport)**
for PR 23153 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23153
@xuanyuanking @HyukjinKwon @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23153
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
24 matches
Mail list logo
