[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-22 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/12569#discussion_r60704478 --- Diff: docs/programming-guide.md --- @@ -1328,12 +1328,18 @@ value of the broadcast variable (e.g. if the variable is shipped to a new node l

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12569#issuecomment-213294575 @jaceklaskowski "Accumulators" is certainly not a complete title. Accumulators .. what? I like @HyukjinKwon 's suggestion. Although it's minor it sets the right

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12569#issuecomment-213282258 @jaceklaskowski Would you accept my PR if I fix a bug in datasource in Spark SQL and I name it as "datasource"? --- If your project is set up for it, you can

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12569#issuecomment-213280716 @jaceklaskowski Because I thought obviously it is not clear. For me it sounds like adding whole documents for Accumulators. As you just said, I think "Added

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-22 Thread jaceklaskowski
Github user jaceklaskowski commented on the pull request: https://github.com/apache/spark/pull/12569#issuecomment-213275339 @HyukjinKwon In that case I'd ask for the alternative as I currently have no idea how to make it clearer (it wasn't me to say "the title is not clear" :)) What

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12569#issuecomment-213166316 @jaceklaskowski I think the title is not clear for the changes this PR has. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/12569#discussion_r60577867 --- Diff: docs/programming-guide.md --- @@ -1328,12 +1328,18 @@ value of the broadcast variable (e.g. if the variable is shipped to a new node l

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12569#discussion_r60552833 --- Diff: docs/programming-guide.md --- @@ -1328,12 +1328,18 @@ value of the broadcast variable (e.g. if the variable is shipped to a new node l

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12569#issuecomment-212817665 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [DOCS][MINOR] Accumulators

2016-04-21 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/12569 [DOCS][MINOR] Accumulators ## What changes were proposed in this pull request? Added screenshot + minor fixes to improve reading ## How was this patch tested?