[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/8391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r39345066 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,10 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r39345352 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,10 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r38473825 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,10 @@ private[sql] class JDBCRDD( */

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/8391#issuecomment-134615781 Hm.. one thing I want to say is, it looks like there is no test code for JdbcRelation. So I tested this with seperate copied functions. It looks just about text

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8391#issuecomment-134698289 There is this: https://github.com/apache/spark/pull/8101 Using docker to test this end-to-end. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/8391#issuecomment-134564538 Hm.. one thing I want to say is, it looks like there is no test code for JdbcRelation. So I tested this with seperate copied functions. It looks just about text

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/8391 [SPARK-10180] [SQL] JDBCRDD does not process EqualNullSafe filter. https://issues.apache.org/jira/browse/SPARK-10180 You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8391#issuecomment-134070250 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37803589 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD( */

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37803622 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD( */

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37833289 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD( */

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37833992 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37830657 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37831947 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD(