Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857345
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857336
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857202
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857200
--- Diff: docs/configuration.md ---
@@ -305,7 +305,7 @@ Apart from these, the following properties are also
available, and may be useful
daily
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857214
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857212
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141894712
> Still, probably best to just merge this, as it's unlikely to cause much
if any trouble.
Would you? I'd greatly appreciate (and propose new changes :-))
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-142061914
[Test build #1780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1780/consoleFull)
for PR 8795 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-142064868
[Test build #1780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1780/console)
for PR 8795 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-142073085
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141783385
Your PR is making the whitespace changes which it ideally would not. I am
not proposing whitespace changes; you are.
It wouldn't make sense to commit the changes
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141779426
Do you want me to split the pull requests to two - one with code formatting
in table and another for the *unfortunate* excessive spaces? And what JIRA
would that
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141827574
The whitespace at the ends of the lines doesn't matter functionally either
way and don't really need 'fixing'. The minor drawback to making such a change
is spurious
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141827044
I disagree with not accepting this change in this version **with** the
superfluous spaces at the end of lines removed -- they're simply a garbage (and
should not
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141675546
It should be better now. While fixing the docs, Atom fixed the additional
spaces at the end (that I remember you mentioned not to fix, but since it was
done
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141678621
I think this is a good change. Yes, the whitespace changes are unfortunate,
and would be better to use an editor that doesn't do that automatically.
---
If your project
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141545586
This much looks good other files need a similar treatment, at least the
`configuration` doc.
---
If your project is set up for it, you can reply to this email and have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141572755
Yeah I think that's worthwhile, as it should be fairly straightforward to
locate instances of this -- look for the areas where tables are used and skim
for backticks. At
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/8795#issuecomment-141569374
So you want me to review the other documents for
no-backtick-code-formatted-in-table issue? I'm fine with it, but just need to
confirm my thinking.
---
If your
20 matches
Mail list logo
