[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-155050652 Merged to master/1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154834406 **[Test build #2011 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2011/consoleFull)** for PR 9432 at commit

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154830736 **[Test build #2007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2007/consoleFull)** for PR 9432 at commit

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154852699 **[Test build #2011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2011/consoleFull)** for PR 9432 at commit

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154821359 **[Test build #2007 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2007/consoleFull)** for PR 9432 at commit

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-07 Thread CharlesYeh
Github user CharlesYeh commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154740151 Oops my bad, also removed the unnecessary sbin/../ from the other tachyon paths --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154003198 **[Test build #1984 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1984/consoleFull)** for PR 9432 at commit

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154038797 **[Test build #1984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1984/consoleFull)** for PR 9432 at commit

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9432#discussion_r44003082 --- Diff: sbin/start-master.sh --- @@ -23,6 +23,26 @@ if [ -z "${SPARK_HOME}" ]; then export SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)" fi

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-05 Thread CharlesYeh
Github user CharlesYeh commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154130413 use SPARK_HOME instead of FWDIR, also changed tachyon check to use SPARK_HOME --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-154179761 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-153689478 Sorry @CharlesYeh this has a merge conflict now. Could you rebase? Basically the scripts have just changed to use a different constructor for finding the working

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-03 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-153452389 This LGTM being basically a copy of the existing approach in `start-thriftserver.sh` et al. It does not appear to interfere with any existing usage of the scripts since

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-03 Thread CharlesYeh
Github user CharlesYeh commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-153446371 Changed it to ./sbin/start-worker.sh and ./sbin/start-master.sh --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11218] [Core] show help messages for st...

2015-11-03 Thread jaceklaskowski
Github user jaceklaskowski commented on the pull request: https://github.com/apache/spark/pull/9432#issuecomment-153362113 Could you change `Usage: Worker [options] ` and `Usage: Master [options]` to be the scripts' names themselves not the cryptic Master and Worker? --- If your