[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-04-15 Thread pravingadakh
Github user pravingadakh closed the pull request at: https://github.com/apache/spark/pull/11575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread pravingadakh
Github user pravingadakh commented on a diff in the pull request: https://github.com/apache/spark/pull/11575#discussion_r55349423 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala --- @@ -178,6 +178,20 @@ class StringIndexerSuite }

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/11575#discussion_r55345145 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala --- @@ -178,6 +178,20 @@ class StringIndexerSuite }

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11575#issuecomment-193685010 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread pravingadakh
Github user pravingadakh commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-193683770 @thunterdb Please refer following PR. [https://github.com/apache/spark/pull/11575](PR) --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread pravingadakh
GitHub user pravingadakh opened a pull request: https://github.com/apache/spark/pull/11575 [SPARK-11535][ML] handling empty string in StringIndexer ## What changes were proposed in this pull request? Replacing "" (not null) with string "EMPTY_STRING" in StringIndexer.

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread pravingadakh
Github user pravingadakh closed the pull request at: https://github.com/apache/spark/pull/9522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-08 Thread pravingadakh
Github user pravingadakh commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-193663512 @thunterdb Hi, I think I messed up while merging, thus closing this pull request creating a new one for the same. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2016-03-07 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-193542005 @pravingadakh sorry for the delay. Would you mind resolving the conflicts? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2015-11-16 Thread pravingadakh
Github user pravingadakh commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-157131275 @jkbradley Any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2015-11-16 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-157204594 @pravingadakh Apologies, but I may need to hold off on review for a bit as we prepare the 1.6 release. Once that's out of the way, I'll be able to resume regular

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2015-11-06 Thread pravingadakh
GitHub user pravingadakh opened a pull request: https://github.com/apache/spark/pull/9522 [SPARK-11535][ML] handling empty string in StringIndexer Replacing "" (not null) with string "EMPTY_STRING" in StringIndexer. Another approach is to use "0" (or next available integer), but it

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-154390716 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your