Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-159190700
I think this message is complete useless. I'd just remove it rather than
spending time bickering about the wording.
---
If your project is set up for it, you can reply
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-159191082
OK, I will close it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user xguo27 closed the pull request at:
https://github.com/apache/spark/pull/9603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-159083050
I just don't see any value. It's obvious that the scheduler is starting /
stopping. I just can't imagine anyone finding this message useful.
---
If your project is
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-159088257
Beyond that, the message is actually somewhat misleading. The "Stopping"
message occurs in `stop()`, which is responsible for stopping the
messageScheduler,
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-159079918
@andrewor14 What is your take on Jacek's comment? I don't think it's a bad
idea to make it more consistent with a matching log message. Please let me
know. Thx!
---
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-157309968
I don't agree with @andrewor14. It does add a value of being consistent
with how Spark informs about its status - if it says "Stopping..." at INFO it
should be
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-157219217
I agree it is trivial, just thought I could quickly add a log statement. If
Jacek agrees, I can close those PR.
---
If your project is set up for it, you can reply to
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9603#issuecomment-156274315
Meh, I don't really think this is worth doing. It doesn't add any value or
fix anything.
---
If your project is set up for it, you can reply to this email and have
Github user xguo27 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9603#discussion_r44728655
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -506,6 +506,7 @@ class SparkContext(config: SparkConf) extends Logging
with
10 matches
Mail list logo
