Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156223468
I'm inclined to agree with Sean, this seems like code churn for the sake
of code churn.
---
If your project is set up for it, you can reply to this email and have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156250766
Do you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156058225
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156262080
I think I should have opened a thread in the mailing list. Sorry, closing
this.
---
If your project is set up for it, you can reply to this email and have your
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/9655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156083460
`fold` is not semantically the same as `foldLeft`. They have different
signatures. `foldLeft` implies the order of the fold matters, and it mostly
does not. Therefore
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156058056
**[Test build #45720 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45720/consoleFull)**
for PR 9655 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156087424
I agree with you. However, if you see the codes, they are used in a mixed
way, even in the same class.
Mostly the usages are `_ and _` or ` + ` but `xxx`
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156159712
It's possible that the differing usages are intentional. Calling `reduce`
makes sense for a truly commutative operation; calling `reduceLeft` suggests
that the operation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156024879
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156024895
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/9655
[SPARK-11687] Mixed usage of fold and foldLeft, reduce and reduceLeft and
reduceOption and reduceLeftOption
https://issues.apache.org/jira/browse/SPARK-11687
As can be seen here
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9655#issuecomment-156025625
**[Test build #45720 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45720/consoleFull)**
for PR 9655 at commit
13 matches
Mail list logo
