Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163718935
I'm not sure this is worth the complexity. I think most users will only
ever drop by name (since dropping a complex expression doesn't really make
sense), and in
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10218#discussion_r47201429
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1271,10 +1271,11 @@ class DataFrame private[sql](
* @since 1.6.0
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163797608
I see. I added this as `sort`, `cube`, `select` and etc do the same thing
for supporting it by name and expression. Although I am not greatly insightful
for this
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163819931
yes please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/10218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163809737
More functions for the sake of more functions does not make the API easier
to use. We should not add functions just to be consistent, we should only add
them if they
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163816325
Thank for the detailed explanation! Then does this mean closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/10218#discussion_r47232368
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1271,10 +1271,11 @@ class DataFrame private[sql](
* @since 1.6.0
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163146790
**[Test build #47412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47412/consoleFull)**
for PR 10218 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163146896
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163146900
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/10218#discussion_r47166749
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1271,10 +1271,11 @@ class DataFrame private[sql](
* @since 1.6.0
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10218#discussion_r47197511
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1271,10 +1271,11 @@ class DataFrame private[sql](
* @since 1.6.0
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/10218
[SPARK-12227][SQL] Support drop multiple columns specified by Column class
in DataFrame API
https://issues.apache.org/jira/browse/SPARK-12227
In this PR, I added the support to drop
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10218#issuecomment-163132221
**[Test build #47412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47412/consoleFull)**
for PR 10218 at commit
15 matches
Mail list logo
